Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
OS X improvement: warnings + bugfix + refactoring, the lot! #1042
This PR fixes the warnings detected by static analyser regarding OS X, as well as clang's warning for regular build. That is, it replaces deprecated
It also improves desktop/fullscreen modes detection for 10.8+ as explained in this comment and how they are handled when creating a fullscreen view.
Furthermore, it importantly refactors SFOpenGLView and splits this monolithic implementation into several files to make it manageable by human being. This way I can implement #614 correctly (already did, actually!)
In addition to all that, it fixes a bug related to fullscreen mode: when resizing a fullscreen window, the fullscreen mode was completely broken.
Finally, in order to anticipates some refactoring for #827: NSImage can now be easily created from raw pixel data.
NB: the branch is still named
Does the iOS code need a similar change perhaps?
I've noticed with the latest master branch code (that I've built for iOS) that on orientation change the resize event is fired and its data shows width and height values that are twice what
It would be preferable for these width/height values to be consistently in the same units and for those units to always be in pixels.
Opened an issue for the problem I’d mentioned. Also wrote a fix and made a pull request for those changes: Bug: iOS orientation change handling re-scales window size by backingScaleFactor #1049. Hope this helps at least on the iOS side of things then.
I'd leave the commit as-is to get a clean build bot feedback. When the missing feature from clang is added, we can always change it back.
We have two choice here: a) assume I do my job right and merge it, or b) put pressure on the community until testers show up. Besides me, who would be in favor of b) -- I cannot stress enough how much I'd love to see more good contributions for OS X from the community.