Build static libraries #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
force-pushed
the
shared_libs
branch
from
bb1fa24
to
e8a00dc
Compare
eXpl0it3r
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Static libraries are a better default since it's less common to need shared libraries. Users who explicitly want shared libs may still enable it if they wish.
This lets us remove
if (WIN32 AND BUILD_SHARED_LIBS)if we'd like to simplify the build script. That's a rather sophisticated bit of CMake code and I worry that it makes the build scripts a lot harder to understand. We're better off hardcodingCMAKE_RUNTIME_OUTPUT_DIRECTORYif we want to make sure all executables and DLLs end up in the same directory.