Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sf::Uint8 with std::uint8_t #217

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Replace sf::Uint8 with std::uint8_t #217

merged 1 commit into from
Sep 21, 2022

Conversation

pifopi
Copy link
Contributor

@pifopi pifopi commented Sep 18, 2022

Hello !

Just a small update because sfml recently replaced sf::Uint8 with std::uint8_t
SFML/SFML@e2528de

The CI fails with mingw errors but it is not linked to my change (only submitting an empty CL to trigger the CI leads to the exact same issue).

Thanks a lot for your work !

@ChrisThrasher
Copy link
Member

ChrisThrasher commented Sep 18, 2022

You can thank me for this new massive API break :) For the record this is a change in the in-development major update to SFML, not in the 2.x series. If we still want to support both SFML 2 and 3 without separate branches and we're okay with using C++11, we can safely switch to the standard fixed width aliases which SFML 3 is already using.

@eliasdaler
Copy link
Contributor

Just to be clear - this change still works with SFML 2.5, right?
(also mingw CI is failing for some reason not related to this PR, I don't have time to fix it right now, unfortunately)

@ChrisThrasher
Copy link
Member

Just to be clear - this change still works with SFML 2.5, right?

I think so? I'm not sure how it would break.

@oprypin
Copy link
Member

oprypin commented Sep 20, 2022

I mean, it could be slightly painful if these types appeared anywhere at the boundary of the API of imgui-sfml, but they don't. Yeah it's safe. And CI passes too, so of course it has to be fine.

@pifopi
Copy link
Contributor Author

pifopi commented Sep 20, 2022

Yes, it's fine with SFML 2.5 ^^

@eliasdaler eliasdaler merged commit e0bf635 into SFML:master Sep 21, 2022
@eliasdaler
Copy link
Contributor

Okay, thanks, everyone! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants