-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 breaks build #1438
Comments
Another reason: pyreadline/pyreadline#73 |
@duanqn Found this in another issue thread, figured this was the correct place to post this. Firstly, glad I'm not the only one coming across this, almost drove me nuts. Luckily I found a relatively clean and arguably better and cleaner way of setting our ${PYTHON_MIN_VERSION_HEX} variable. I'll outline the relatively simple fix here.
Now, All we need to do is shift the major version up by 24 bits, and minor version up by 16
The fix I made (making, will send a PR after this)
see cmake page for math that allows c like bit manipulation operations |
@sarcXD This looks great! |
FindPython.cmake assumes python minor version is single digit.
The text was updated successfully, but these errors were encountered: