Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower minimum required version of importlib.metadata #97

Merged

Conversation

aphedges
Copy link
Collaborator

@aphedges aphedges commented Sep 3, 2024

I had problems installing a package that required daidepp because daidepp requires too recent a version of importlib.metadata. Commit d31a7d51 added the requirement for importlib.metadata with a minimum version of 6.0.0. The commit was made on 2023-02-08, and 6.0.0 was the latest version available at the time.2 However, according to the README,3 1.4.0 was the version used by the Python 3.8 stdlib, so no newer version is needed. I have loosened the requirement accordingly.

Footnotes

  1. https://github.com/SHADE-AI/daidepp/commit/d31a7d5b620eec3220631db723957dfb376f1085

  2. https://pypi.org/project/importlib-metadata/#history

  3. https://pypi.org/project/importlib-metadata/#description

I had problems installing a package that required `daidepp` because
`daidepp` requires too recent a version of `importlib.metadata`. Commit
d31a7d5[^1] added the requirement for `importlib.metadata` with a
minimum version of `6.0.0`. The commit was made on 2023-02-08, and
`6.0.0` was the latest version available at the time.[^2] However,
according to the README,[^3] `1.4.0` was the version used by the Python
3.8 stdlib, so no newer version is needed. I have loosened the
requirement accordingly.

[^1]: SHADE-AI@d31a7d5
[^2]: https://pypi.org/project/importlib-metadata/#history
[^3]: https://pypi.org/project/importlib-metadata/#description
@mjspeck
Copy link
Collaborator

mjspeck commented Sep 3, 2024

Thanks! Out of curiosity, what's the package that requires daidepp?

@mjspeck mjspeck merged commit 61b9f2a into SHADE-AI:main Sep 3, 2024
1 check passed
@aphedges
Copy link
Collaborator Author

aphedges commented Sep 3, 2024

Thanks for merging!

We (USC ISI, UMD, and University of Sydney) are continuing the experiments from SHADE, and I've been working on a framework for our agents: https://github.com/ALLAN-DIP/chiron-utils. We aren't communicating with DAIDE anymore, but daidepp provides a more structured way to express moves internally than using the standard and informal move syntax from the game.

@mjspeck
Copy link
Collaborator

mjspeck commented Sep 3, 2024

@aphedges That's great! I'm glad to see that this work is still being used. Since you're actively working with daidepp I can also elevate you to a maintainer on the project if you'd like.

@aphedges
Copy link
Collaborator Author

@mjspeck, I forgot to respond to your comment 2 months ago, but yes, elevating me to be a maintainer would be appreciated!

@mjspeck
Copy link
Collaborator

mjspeck commented Nov 12, 2024

Done!

@aphedges
Copy link
Collaborator Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants