Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for basic crud #56

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

longfangsong
Copy link
Collaborator

Signed-off-by: longfangsong longfangsong@icloud.com

What problem does this PR solve?

Issue Number: close part of #16

Problem Summary:

缺少基本 CRUD API 的功能测试

What is changed and how it works?

What's Changed:
添加这部分测试,并在CI中自动运行

(真的发现了几个bug,测试真的很重要!)

Signed-off-by: longfangsong <longfangsong@icloud.com>
self.assertEqual(student['birthday'], '1990-01-01T00:00:00Z')

def test_scan(self):
response = urllib.request.urlopen('http://localhost:8000/students?limit=100&offset=0').read().decode('utf-8')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谁会写装饰器的到时候把这些口水话抽象一个

@longfangsong longfangsong merged commit 653620e into SHUReeducation:master Aug 6, 2020
@longfangsong longfangsong deleted the crud-test branch August 10, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants