Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue149 #150

Merged
merged 9 commits into from
Sep 27, 2021
Merged

Fix issue149 #150

merged 9 commits into from
Sep 27, 2021

Conversation

pscff
Copy link
Collaborator

@pscff pscff commented Sep 22, 2021

For testing on Windows, set the ENVIRONMENT PATH correctly so dlls generated during the build can be found.

The following tests are still failing:

26 - test_storage (Failed)
38 - test_mapping (Failed)
39 - test_pyembed (Failed)
40 - test_python_mapping (Failed)
49 - test_json_storage (Failed)
52 - test_yaml_storage (Failed)

Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. I am able to reproduce

@jesper-friis jesper-friis changed the base branch from master to windows-compile September 27, 2021 14:36
@jesper-friis jesper-friis merged commit 50b6b87 into windows-compile Sep 27, 2021
@jesper-friis jesper-friis deleted the fix_issue149 branch August 28, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests 24-55 on Windows are failing: dlls generated during the build cannot be found
2 participants