Fix/reference to iterator variable causes pointer problems #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go-pas-client we convert the public models from the user to the interal models used for the actual request. In this conversion, when converting the band alarms list we do this:
This causes a problem when the ToInternal function on bandAlarm operates on a pointer to the struct rather than the struct itself. The function return an object with values that point back into the iterator variable and when we have more than one item in the list these values are set to the last value that was set in the iterator variable.