Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nuget package assets #116

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Fixed nuget package assets #116

merged 1 commit into from
Jul 21, 2022

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Jul 20, 2022

No description provided.

@tznind
Copy link
Contributor Author

tznind commented Jul 20, 2022

Ignore that CI message about spaCy was on a stale branch...

Updated: ok scratch that, its also failing on this branch

Logging to None
  File "ner_daemon_spacy.py", line 227, in <module>
  File "ner_daemon_spacy.py", line 144, in __init__
  File "spacy/__init__.py", line 51, in load
  File "spacy/util.py", line 427, in load_model
OSError: [E050] Can't find model 'en_core_web_md'. It doesn't seem to be a Python package or a valid path to a data directory.
[14669] Failed to execute script 'ner_daemon_spacy' due to unhandled exception!
Error: Process completed with exit code 1.

@tznind
Copy link
Contributor Author

tznind commented Jul 20, 2022

Hmn our ci package command is

 dotnet pack NuGet/IsIdentifiable.NuGet.csproj -c Release --include-source --include-symbols --nologo -p:NuspecFile=`pwd`/NuGet/IsIdentifiable.NuGet.nuspec -p:NuspecProperties=Version=$(fgrep AssemblyInformationalVersion SharedAssemblyInfo.cs|cut -d'"' -f2)\;configuration=Release  -p:SymbolPackageFormat=snupkg

that makes me wonder if we need that assets path in there too

@tznind
Copy link
Contributor Author

tznind commented Jul 20, 2022

I think if we can get #113 working (build from csproj and scrap teh NuGet project/nuspec that would be preferrable.

@jas88
Copy link
Member

jas88 commented Jul 20, 2022

Just run ./ner_daemon_spacy.py -d en_core_web_md (at least on a branch that has -d implemented) and it'll download the missing en_core_web_md file for you, or grab it manually from https://github.com/explosion/spacy-models/releases/download/en_core_web_md-3.4.0/en_core_web_md-3.4.0-py3-none-any.whl and put it ... wherever it is spaCy expects it installed. (I have no idea about Python packaging, but apparently that's a "wheel" file with Python bits in, maybe comparable to a .nupkg?) There's documentation about it in spaCy's docs somewhere.

@jas88
Copy link
Member

jas88 commented Jul 20, 2022

I think if we can get #113 working (build from csproj and scrap teh NuGet project/nuspec that would be preferrable.

I'll rebuild #113 and get it working+merged properly next.

@tznind
Copy link
Contributor Author

tznind commented Jul 21, 2022

Need to prioritise this if possible. I don't like having missing dlls in a new release. 0.0.5 doesn't even seem to have libleptonica in it at all so users can't even apply the manual copying workaround.

@jas88 jas88 merged commit 567f992 into main Jul 21, 2022
@jas88 jas88 deleted the fix-assets2 branch July 21, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants