Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fodicom5 2 #1121

Closed
wants to merge 3 commits into from
Closed

Feature/fodicom5 2 #1121

wants to merge 3 commits into from

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Mar 30, 2022

Updating HIC.BadMedicine.Dicom and DicomTypeTranslation

dependabot bot and others added 3 commits March 25, 2022 15:19
Bumps [HIC.DicomTypeTranslation](https://github.com/HicServices/DicomTypeTranslation) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/HicServices/DicomTypeTranslation/releases)
- [Changelog](https://github.com/HicServices/DicomTypeTranslation/blob/main/CHANGELOG.md)
- [Commits](SMI/DicomTypeTranslation@3.0.0...4.0.0)

---
updated-dependencies:
- dependency-name: HIC.DicomTypeTranslation
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@tznind
Copy link
Contributor

tznind commented Mar 30, 2022

We should probably wait till #1042 is merged before merging this. We don't want to make any code changes or compatibility changes in code that has been shipped off to that repository already.

@jas88 jas88 closed this Apr 28, 2022
@jas88 jas88 deleted the feature/fodicom5-2 branch April 28, 2022 15:10
@rkm
Copy link
Member

rkm commented May 11, 2022

@jas we can probably re-try this upgrade now

@jas88
Copy link
Member Author

jas88 commented May 11, 2022

@rkm Already done as part of another PR - the newer RdmpDicom used fo-dicom, RDMP's API changed slightly so we needed the new RdmpDicom to use the new RDMP, which is why #1143 hit new size records for a Dependabot-created PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants