Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #8 by ensuring that orbital colours will be consistent across multiplots and between re-plot calls from an interactive notebook.
A dict
sumo.plotting.colour_cache
is held at the plotting level (as other plots may wish to share this information) and initialised as{}
; when the dos_plotter does not find an orbital colour specified in thecolours
argument it will take the next item from a cycle and update the cache with{element: {orbital: colour}}
. To clear the cache and start the colour cycle from the beginning, this module-level variable can be manually reset to{}
. This would rarely be necessary: I still recommend that any real colour tweaking should be done by passing a dict or config directly.Tests are included and currently pass.