Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct bugs in Likelihood computation #634

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Correct bugs in Likelihood computation #634

merged 9 commits into from
Aug 20, 2024

Conversation

Paul-Saves
Copy link
Contributor

@Paul-Saves Paul-Saves commented Jul 25, 2024 •
edited
Loading

  • Properly check if the kriging gradient of the likelihood can be computed in the function after calling the likelihood function.
    Initialize with default values and return such default values if the computation of the likelihood function has not work properly for the given theta. Thanks to Nathalie Bartoli!
  • Avoid the FloatingPoint error when the data is highly non-normal for high hyperaparameters values and add a warning. Thanks to Enrico Stragiotti!

@Paul-Saves Paul-Saves changed the title Correct a problem with the initialization of parameters when computing kriging gradients Correct bugs in Likelihood computation Aug 7, 2024
@relf relf merged commit 96a630a into SMTorg:master Aug 20, 2024
11 checks passed
Paul-Saves added a commit to Paul-Saves/smt that referenced this pull request Sep 16, 2024
@Paul-Saves
Correct bugs in Likelihood computation (SMTorg#634)
fef219a 
* fix tnc

* fix floating point operator

* add test

* change test'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paul-Saves @relf