Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query TNS and populate candidate marshal #11

Merged
merged 12 commits into from
Dec 15, 2020
Merged

Conversation

emirkmo
Copy link
Member

@emirkmo emirkmo commented Oct 26, 2020

Script that 1) querys TNS using requests (their API does not allow searching like we want) 2) makes GET requests on new targets using TNS API 3) populates candidate marshal using flows API.

We're currently using this script to populate the flows candidate marshal from the TNS with new candidates. Ideally, we would integrate this with the website so that the users can press a button to run it and pull the latest changes with the default values.

This script requires a new line in the config.ini file for the TNS bot api key. (I'll send that to you privately.) Technically, anyone can now use it to query the TNS for a wide range of candidates and upload those to flows.

Currently, I'm basically running this once a day to help plan our observations.

Script that 1) querys TNS using requests (their API does not allow searching like we want)  2) makes GET requests on new targets using TNS API 3)  populates candidate marshal using flows API.
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #11 (1ac3b20) into devel (db2b3bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #11   +/-   ##
=======================================
  Coverage   18.58%   18.58%           
=======================================
  Files          21       21           
  Lines        1367     1367           
=======================================
  Hits          254      254           
  Misses       1113     1113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2b3bf...1ac3b20. Read the comment docs.

@emirkmo emirkmo mentioned this pull request Oct 26, 2020
5 tasks
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
@emirkmo
Copy link
Member Author

emirkmo commented Nov 18, 2020

Ok I handled the majority of your comments. Let's leave fixing the query string as a todo because I'm having some difficulty with it and it's not necessary to get a basic version working. I made #15 to track that so we don't forget. I've also skipped trying to come up with a clever regex but feel free to change that if you want to. I prefer to avoid it.

I'll do one final check then tag you if it should be merged

run_querytns.py Outdated Show resolved Hide resolved
run_querytns.py Outdated Show resolved Hide resolved
@emirkmo
Copy link
Member Author

emirkmo commented Dec 4, 2020

Ok I made the changes. I think we can merge now.

@rhandberg
Copy link
Contributor

I think I wil just merge this now, and make the last couple of changes myself

@rhandberg rhandberg merged commit f17af57 into SNflows:devel Dec 15, 2020
@emirkmo
Copy link
Member Author

emirkmo commented Dec 15, 2020

Thanks Rasmus, looking great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants