Make CMake subdirectory usage easier #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows targets to be used the same way when included as a subdirectory as when using find_package (when using as a subdirectory, the existing non-namespace usage still works too).
This removes the need to use target_include_directories when including SOCI as a subdirectory, making subdir usage the same as find_package usage.
|
The new way to use SOCI in a subdirectory is definitely much nicer to me than the old one, thanks for improving this! If there are no objections, I'm going to merge this in a couple of days. Thanks again! |
|
Any news/update on this? :) |
|
You're right, this should have been merged already -- done now. |
Merged
vadz
added a commit
to vadz/soci
that referenced
this pull request
Sep 14, 2022
Use "Soci::" rather than "SOCI::" as the prefix, for consistency with the other CMake variables defined by FindSoci.cmake. Do not use "soci_" prefix for the library names which is completely redundant with the other prefix, writing "Soci::soci_" is clearly redundant. See SOCI#982.
Krzmbrzl
pushed a commit
to Krzmbrzl/soci
that referenced
this pull request
Sep 15, 2022
Use "Soci::" rather than "SOCI::" as the prefix, for consistency with the other CMake variables defined by FindSoci.cmake. Do not use "soci_" prefix for the library names which is completely redundant with the other prefix, writing "Soci::soci_" is clearly redundant. See SOCI#982.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tweaks will allow users to use SOCI as a subdirectory with CMake the same way as if they had called
find_package(targets in theSOCI::namespace, and no additional call totarget_include_directories).Everything should be backwards-compatible - the internal non-namespace targets continue to work as they did before, and if someone used
target_include_directoriesas before it wouldn't break anything.I also updated the documentation and examples to reflect the simplified usage.
Please let me know if you have any comments or want me to change anything. Thanks!