Added specialized bytecodes with common constants #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…nually Signed-off-by: Stefan Marr <git@stefan-marr.de>
These bytecodes are very common and may benefit from specialization in the interpreter. Signed-off-by: Stefan Marr <git@stefan-marr.de>
These are common bytecodes, which we specialize to increase interpreter performance. Note that I don't change the bytecode length for these, even so we only need 1 byte. Though, because these are quickened into place, it's easier to keep them at 3 bytes. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Removing this is mostly about performance, which is a little unfortunate. Signed-off-by: Stefan Marr <git@stefan-marr.de>
The bytecode profile indicates only 0 and 1 as common literals. There are a few others, but those are really benchmark specific. I added `nil` even though it's not super common, but it may be useful. Give the varity of constants that are pushed, having push_constant_0..2 seems useful as a short cut and shorter version of the standard bytecode. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds:
push_frame/pop_frameto access indexes 0, 1, and 2push_inner/pop_innerto access indexes 0, 1, and 2push_field/pop_fieldto access indexes 0 and 1push_constant/pop_constantto access indexes 0, 1, and 2push_0,push_1,push_nilwhich push the corresponding constantsPerformance impact is minimal. This might reduce run time on the SomSom benchmarks by 2%.
https://rebench.stefan-marr.de/compare/RPySOM/1439149b558ac2b722eea02f2843e69f11ded684/6f840bdb10f46872c2df340a482d767e9eca0116