Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CanBICs layer #76

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add CanBICs layer #76

wants to merge 11 commits into from

Conversation

finnshort
Copy link
Contributor

Add Colin's canbics layer with info popup and french translation

@finnshort finnshort requested a review from dgboss March 2, 2022 06:01
dgboss
dgboss approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works great, but I don't really understand the purpose of the layer. All I see is a bunch of blue lines on the map and I have no idea what they mean. The popup from the legend mentions three levels, but I don't see three categories.

mapApp/templates/mapApp/util/tips.html Outdated Show resolved Hide resolved
@finnshort
Copy link
Contributor Author

Everything works great, but I don't really understand the purpose of the layer. All I see is a bunch of blue lines on the map and I have no idea what they mean. The popup from the legend mentions three levels, but I don't see three categories.

Yess I had the same thought. I'll shoot Karen and Colin a follow up email to see if they can offer any clarification before pushing the changes.

dgboss
dgboss requested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dgboss
Copy link
Contributor

dgboss commented Apr 26, 2022

Hey Finn, just checking in to see if you need anything from me on this PR?

@finnshort
Copy link
Contributor Author

Hey Finn, just checking in to see if you need anything from me on this PR?

No, thanks for following up! Colin wants to make some changes to the layers before we add them in. I'll change this PR back to a draft for now.

@finnshort finnshort marked this pull request as draft April 26, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnshort @dgboss