Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brune and Smoothed Brune source time functions #1649

Closed
wants to merge 3 commits into from
Closed

Brune and Smoothed Brune source time functions #1649

wants to merge 3 commits into from

Conversation

homnath
Copy link

@homnath homnath commented Nov 16, 2023

  • Implemented Brune and Smoothed Brune source time functions for testing.

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (fb8310f) 51.51% compared to head (6c57e3f) 51.48%.

Files Patch % Lines
src/specfem3D/comp_source_time_function.f90 0.00% 14 Missing ⚠️
src/specfem3D/locate_source.F90 0.00% 6 Missing ⚠️
src/specfem3D/compute_add_sources_viscoelastic.F90 0.00% 4 Missing ⚠️
src/specfem3D/get_force.f90 0.00% 4 Missing ⚠️
src/specfem3D/setup_sources_receivers.f90 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1649      +/-   ##
==========================================
- Coverage   51.51%   51.48%   -0.03%     
==========================================
  Files         266      266              
  Lines       60104    60134      +30     
==========================================
- Hits        30961    30959       -2     
- Misses      29143    29175      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpampuero
Copy link
Contributor

Hi Hom Nath. These new Brune STFs are moment functions (they tend to a non-zero value at long times), whereas the other ones in the code are moment RATE functions (they go back to zero at long times). That could be confusing for users. Is that intentional?

@jpampuero jpampuero mentioned this pull request Nov 16, 2023
Open
@homnath
Copy link
Author

homnath commented Nov 16, 2023

@jpampuero
Hi Pablo,
Thank you so much for the important feedback. I have just implemented them for testing purposes. Please let us know how to implement them more accurately and efficiently.
Best,
Hom Nath

@jpampuero
Copy link
Contributor

To make it a moment rate, you just need to replace the function by its time derivative.
P

danielpeter
danielpeter reviewed Nov 16, 2023
View reviewed changes
DATA/CMTSOLUTION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleting this file shouldn't occur. all the file in the root DATA/ folder are symlinks to the DATA/ files in the example EXAMPLES/applications/homogeneous_halfspace/

DATA/CMTSOLUTION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR shouldn't touch this file.

DATA/Par_file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

DATA/Par_file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

DATA/STATIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

DATA/STATIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

m4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR shouldn't touch the m4/ folder. the content in m4/ has been updated to the most recent CIG version just recently.

src/specfem3D/compute_add_sources_viscoelastic.F90
! Brune source time function
! hdur is the rise time
! Frequency parameter:
f0=2.0d0*PI/hdur(isource)
Copy link
Contributor

@danielpeter danielpeter Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to add the factor 2 PI in the source time function, similar as done above for the other functions.

src/specfem3D/compute_add_sources_viscoelastic.F90
! Smoothed Brune source time function
! hdur is the rise time
! Frequency parameter:
f0=2.0d0*PI/hdur(isource)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@danielpeter
Copy link
Contributor

closing the PR - mainly because of the DATA/ and m4/ changes that seem to be unrelated and by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpeter danielpeter danielpeter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@homnath @jpampuero @danielpeter