Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils testing #22

Merged
merged 15 commits into from
Nov 3, 2021
Merged

Utils testing #22

merged 15 commits into from
Nov 3, 2021

Conversation

vinferrer
Copy link
Member

@vinferrer vinferrer commented Nov 1, 2021

Partially #11 .

Changes proposed in this pull request:

  • Add tests to the utils functions
  • Eliminates unused wfusion option

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #22 (c926222) into main (8825f7f) will increase coverage by 13.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #22       +/-   ##
===========================================
+ Coverage   49.26%   63.06%   +13.79%     
===========================================
  Files           3        6        +3     
  Lines         205      333      +128     
===========================================
+ Hits          101      210      +109     
- Misses        104      123       +19     
Impacted Files Coverage Δ
connPFM/utils/hrf_generator.py 87.80% <ø> (ø)
connPFM/utils/surrogate_generator.py 96.29% <100.00%> (ø)
connPFM/utils/atlas_mod.py 57.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8825f7f...c926222. Read the comment docs.

@vinferrer vinferrer marked this pull request as draft November 1, 2021 09:29
@vinferrer vinferrer changed the title ´Utils´ testing Utils testing Nov 1, 2021
@vinferrer
Copy link
Member Author

@eurunuela, do we need these lines?

if self.wfusion:

@eurunuela
Copy link
Contributor

@eurunuela, do we need these lines?

if self.wfusion:

You can remove the code in that if statement.

@vinferrer vinferrer marked this pull request as ready for review November 2, 2021 11:27
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vinferrer

@vinferrer vinferrer merged commit 4680217 into SPiN-Lab:main Nov 3, 2021
@vinferrer vinferrer deleted the utils_testing branch November 4, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants