Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ETS plots max and min values #25

Merged
merged 26 commits into from
Dec 9, 2021
Merged

Change ETS plots max and min values #25

merged 26 commits into from
Dec 9, 2021

Conversation

vinferrer
Copy link
Member

@vinferrer vinferrer commented Nov 5, 2021 •
edited
Loading

Closes # .

Changes proposed in this pull request:

  • Plot both original and denoised matrix
  • Add RSS plot

@vinferrer vinferrer marked this pull request as draft November 5, 2021 15:26
@vinferrer
Copy link
Member Author

image
Left it's ets_AUC, Right ets_original, both with the thresholding for selected RSS

@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited
Loading

Codecov Report

Merging #25 (5d86362) into main (2df164e) will increase coverage by 2.69%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   86.15%   88.84%   +2.69%     
==========================================
  Files          15       15              
  Lines         816      825       +9     
==========================================
+ Hits          703      733      +30     
+ Misses        113       92      -21
Impacted Files Coverage Δ
connPFM/cli/connPFM.py 100.00% <ø> (ø)
connPFM/connectivity/plotting.py 96.55% <90.90%> (+43.49%) ⬆️
connPFM/connectivity/ev.py 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df164e...5d86362. Read the comment docs.

@vinferrer
Copy link
Member Author

ets_AUC_denoisedrss

@vinferrer vinferrer marked this pull request as ready for review December 9, 2021 11:19
eurunuela
eurunuela requested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Just have one comment.

connPFM/tests/test_ev.py Show resolved Hide resolved
@vinferrer
Copy link
Member Author

All done @eurunuela

eurunuela
eurunuela approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vinferrer !

@vinferrer vinferrer merged commit 17b9cbb into SPiN-Lab:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinferrer @eurunuela