Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup connPFM installation with pip #8

Merged
merged 7 commits into from
Oct 6, 2021
Merged

Setup connPFM installation with pip #8

merged 7 commits into from
Oct 6, 2021

Conversation

vinferrer
Copy link
Member

Closes #3 .

Changes proposed in this pull request:

  • add required packages to info.py
  • add dummy workflow function
  • add entrypoint to setup.cfg for connPFM

eurunuela
eurunuela requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there's a little change I'd make.

README.md Show resolved Hide resolved
connPFM/connPFM.py Show resolved Hide resolved
eurunuela
eurunuela approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vinferrer

@vinferrer vinferrer merged commit 99f8fee into SPiN-Lab:main Oct 6, 2021
@vinferrer vinferrer deleted the install branch November 4, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make pip install work
2 participants
@vinferrer @eurunuela