improved error handling

Author: jtarquino

appveyor.yml

@@ -90,16 +90,19 @@ test_script:
     # Enable additional file formats
     $newSettings = New-Object PSCustomObject -Property @{"PropertyValues" = @( @{"@odata.type"="#Model.Property"; "Name" = "AllowedResourceExtensionsForUpload"; "Value" = "*,*.xml,*.xsd,*.xsl,*.png,*.gif,*.jpg,*.tif,*.jpeg,*.tiff,*.bmp,*.pdf,*.svg,*.rtf,*.txt,*.doc,*.docx,*.pps,*.ppt,*.pptx,*.xlsx"})}
     $stringNewRequest =  $newSettings | ConvertTo-JSON -Depth 5
-    for ($i=0 ; $i -le 10 -and $sucess -eq $false ;i++){
+    $isAllowedFileFormatUpdated = $true
+    for ($i=0 ; $i -le 10 -and $isAllowedFileFormatUpdated -eq $false ;i++){
         try{
-            $sucess = $true;
+            $isAllowedFileFormatUpdated = $true;
             Invoke-RestMethod -Uri "http://localhost/reports/api/v1.0/ReportServerInfo/Model.UpdateSettings" -Method POST -UseDefaultCredentials -ContentType 'application/json' -Body $stringNewRequest
         }
         catch (){
-            $sucess = $false
+            $isAllowedFileFormatUpdated = $false
             Start-Sleep -Seconds 1
         }
     }
+    if (isAllowedFileFormatUpdated -eq $false) {throw (New-Object System.Exception("Failed to update the AllowedResourceExtensionsForUpload") }
+    
     
     # Integration test section
     # Activate verbose on Powershell