Port to C++: Morphological Operations #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use a proper naming convention for all files eg: algorithm.hpp and algo.cpp instead of using main.cpp and helper.hpp for every algorithm. |
* Rename main.cpp to relevenat 'algo'.cpp * Modify Makefile accordingly
|
Renamed main.cpp to 'algo'.cpp |
|
Use a single helper.hpp then instead of multiple copies of the same file |
1] Generalised modules for any size kernel 2] Modified file structure 3] Added module for padding of images
Kindly review |
amanchhaparia
requested changes
Mar 22, 2023
- Break long paragraphs in smaller sections.
- Add comments
Rename Readme.md -> README.md
- made separate src and include folder
- helper.cpp -> morphology.cpp - helper.hpp -> morphology.hpp
amanchhaparia
approved these changes
Mar 23, 2023
aPR0T0
pushed a commit
to aPR0T0/Pixels_Seminar
that referenced
this pull request
Mar 23, 2023
* added code for erosion and dilation * added code for opening, closing and gradient * added readme * removed template files * added assets folder * changed path for images * Change naming scheme * Rename main.cpp to relevenat 'algo'.cpp * Modify Makefile accordingly * Major changes 1] Generalised modules for any size kernel 2] Modified file structure 3] Added module for padding of images * Add new image to assets folder * Add dependencies to Makefiles * Take image path as commandline argument * Remove redundant files * - Add table of contents - Break long paragraphs in smaller sections. * - Remove redundant function from helper.hpp - Add comments * Rename Assets->assets Rename Readme.md -> README.md * Revert Makefile changes * Change format of helper.hpp - made separate src and include folder * Modify Makefile * Change path of include file * Rename files - helper.cpp -> morphology.cpp - helper.hpp -> morphology.hpp * Change image path * Change helper -> morphology --------- Co-authored-by: Smit1603 <smuffinboy16@gmail.com>
Khushi-Balia
pushed a commit
to Khushi-Balia/Pixels_Seminar
that referenced
this pull request
Mar 28, 2023
* added code for erosion and dilation * added code for opening, closing and gradient * added readme * removed template files * added assets folder * changed path for images * Change naming scheme * Rename main.cpp to relevenat 'algo'.cpp * Modify Makefile accordingly * Major changes 1] Generalised modules for any size kernel 2] Modified file structure 3] Added module for padding of images * Add new image to assets folder * Add dependencies to Makefiles * Take image path as commandline argument * Remove redundant files * - Add table of contents - Break long paragraphs in smaller sections. * - Remove redundant function from helper.hpp - Add comments * Rename Assets->assets Rename Readme.md -> README.md * Revert Makefile changes * Change format of helper.hpp - made separate src and include folder * Modify Makefile * Change path of include file * Rename files - helper.cpp -> morphology.cpp - helper.hpp -> morphology.hpp * Change image path * Change helper -> morphology --------- Co-authored-by: Smit1603 <smuffinboy16@gmail.com>
|
Can you add usage instructions to the morphology readme? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to issue #50
Added examples
1. erosion
2. dilation
3. opening
4. closing
5. gradient
Added helper functions
Added readme similar to previous year's morphology.