Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "coucou" log in LeanbackPlayerFragment. #397

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Remove "coucou" log in LeanbackPlayerFragment. #397

merged 4 commits into from
Jan 18, 2024

Conversation

Loic-Dumas
Copy link
Collaborator

@Loic-Dumas Loic-Dumas commented Jan 18, 2024 •
edited
Loading

Pull request

Description

Remove "coucou" log in LeanbackPlayerFragment.

MGaetan89
MGaetan89 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I'd say that these logs could even be removed, but I'm fine either way 🙂

@StaehliJ
Copy link
Contributor

Same as @MGaetan89 says, I would remove logs instead.

StaehliJ
StaehliJ requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove log instead.

MGaetan89
MGaetan89 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StaehliJ StaehliJ added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 25bb6cd Jan 18, 2024
8 checks passed
@StaehliJ StaehliJ deleted the Remove-Coucou-log branch January 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Loic-Dumas @StaehliJ @MGaetan89