Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a seek bar to the TV demo player #543

Merged
merged 1 commit into from
May 21, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented May 15, 2024

Pull request

Description

This PR adds a seek bar to the player in the TV demo, so it is easier to seek backward/forward in the current media.

Changes made

  • Create a TVSlider component.
  • Reorganise the PlayerView so it has a clearer structure:
    • The chapter/segment info at the top.
    • The playback actions in the middle.
    • The settings button, skip button, and seek bar at the bottom.

Screenshots

Description Screenshot
Seek bar unfocused Screenshot_20240515_090121
Seek bar focused Screenshot_20240515_090131
Seek bar disabled Screenshot_20240515_090211
Skip button with controls Screenshot_20240515_090307
Skip button without controls Screenshot_20240515_090309

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue May 15, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 15, 2024

Code Coverage

Overall Project 49.6% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 force-pushed the 377-add-a-seekbar-to-the-player-on-tv branch from b83cea6 to d852e57 Compare May 21, 2024 07:18
@StaehliJ
Copy link
Contributor

For a first step it is ok. For long video or audio duration it is tedious. A seek acceleration could be nice in that case.

@StaehliJ StaehliJ added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 1b809a2 May 21, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 377-add-a-seekbar-to-the-player-on-tv branch May 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add a seekbar to the player on TV
2 participants