Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

605 bad commandersact stop position after removing item #606

Merged
merged 6 commits into from
Jun 25, 2024
Merged

605 bad commandersact stop position after removing item #606

merged 6 commits into from
Jun 25, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jun 25, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to fix the position sent by stop event with CommandersAct when it is stopped by removing the last MediaItem.

Changes made

  • Detect PillarboxData changes only when Timeline change occurs due to TIMELINE_CHANGE_REASON_SOURCE_UPDATE.

Fixes

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Jun 25, 2024 that may be closed by this pull request
Bad CommandersAct stop position after removing item #605
Closed
1 task
@StaehliJ StaehliJ added the bug Something isn't working label Jun 25, 2024
@StaehliJ StaehliJ requested a review from MGaetan89 June 25, 2024 12:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Code Coverage

Overall Project 50.97% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 50.42% 🟢
Files
Module File Coverage
:pillarbox-player CurrentMediaItemPillarboxDataTracker.kt 100% 🟢

@StaehliJ StaehliJ enabled auto-merge June 25, 2024 15:20
@StaehliJ StaehliJ added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 641dae4 Jun 25, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 605-bad-commandersact-stop-position-after-removing-item branch June 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad CommandersAct stop position after removing item
2 participants
@StaehliJ @MGaetan89