Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fortran #49

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Support for Fortran #49

merged 5 commits into from
Jun 9, 2021

Conversation

alexbernat
Copy link
Contributor

This PR adds a gflang executable along with the associated environment variables, in pursuit of Fortran/Flang support.

@ianamason
Copy link
Member

Thanks for this. It invokes a touch of deja vu for me. Someone else added a wfortran to the wllvm toolset, though it looks like it never made it to the README.
I have no idea if it ever got used. Do you use gflang?

@alexbernat
Copy link
Contributor Author

Yes, I've found it to be quite useful for scientific applications that have a mix of C and FORTRAN.

Copy link
Member

@ianamason ianamason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this, as is, will screw up the imports, plus the module file looks like
a frankenstein. I guess this is one downside of golang.

Can you fix the pull request so that stuff isn't in it?

@alexbernat
Copy link
Contributor Author

alexbernat commented Jun 9, 2021

I'm sorry to do this, but I mostly write C and don't have a ton of golang experience, so do you mind describing the issue a bit further and I'll be happy to fix it?

Copy link
Member

@ianamason ianamason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any mention of this should be

"github.com/alexbernat/gllvm/shared"

replaced by the original

"github.com/SRI-CSL/gllvm/shared"

and the module file should be restored to the original.

No biggie.

@alexbernat
Copy link
Contributor Author

Should be good to go, sorry about that.

Copy link
Member

@ianamason ianamason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost. gclang++/main.go and get-bc/main.go need some TLC too.

@alexbernat
Copy link
Contributor Author

alexbernat commented Jun 9, 2021

Super sorry - I don't see what you mean - those files appear to have no changes to them when diffed with master in the most recent commit?

@ianamason ianamason merged commit df36a3b into SRI-CSL:master Jun 9, 2021
@ianamason
Copy link
Member

Great. I hate the web interface to these pull requests. Such a hairball.

@alexbernat
Copy link
Contributor Author

Agreed. Thanks!

@ianamason
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants