-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cross-compilation via -target ...
option
#72
Conversation
Got any idea why the tests are failing? |
I think objcopy should remain the default, ONLY because it is a good idea to maintain backward compatibility. Then you won't need to alter the documentation. Maybe also this is the cause of the test failure? |
Hi, I noticed the tests failing. I'm heading back home now, but tomorrow
morning I'll edit the PR!
Il mer 23 ago 2023, 17:12 Ian A Mason ***@***.***> ha scritto:
… I think objcopy should remain the default, ONLY because it is a good idea
to maintain backward compatibility. Then you won't need to alter the
documentation. Maybe also this is the cause of the test failure?
—
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6ICSASIZ7OE6XKHWT4XWLXWYMW3ANCNFSM6AAAAAA33NFSZI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi, I just implemented what you mentioned in the issue #71:
Let me know if everything looks fine to you, and thanks for all your help along the way! |
Thanks @umbertov I’ll merge it in when I get home. Thanks again. |
hey @ianamason github noticed me that a test is failing; specifically, I tried reproducing it on my machine with
|
I'll look into it once I have merged it in. The current, premerge, fails on my M1 so I guess it is unrelated. |
Yes it succeeds on my M1 too, so it is probably just bitrot with the test. I'll look into it. |
Hi, as discussed in the issue #71 , I propose the following two changes:
-target ARCHITECTURE
inshared/parser.go
llvm-objcopy
because that's what comes with the LLVM toolchain, which supports any target. This changes the pre-existing default ofobjcopy
from the GNU toolchain, which only supports the native compilation target (i.e. x86 on x86 machines, arm on arm machines).If someone still wishes to use GNU
objcopy
, they can still use it by setting theGLLVM_OBJCOPY=objcopy
environment variable for native targets, or the prefixed version for cross-compilation toolchains, e.g.GLLVM_OBJCOPY=aarch64-linux-gnu-objcopy
for arm64.