Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check parallel #488

Merged
merged 15 commits into from
Feb 21, 2024
Merged

Check parallel #488

merged 15 commits into from
Feb 21, 2024

Conversation

Ovascos
Copy link
Contributor

@Ovascos Ovascos commented Feb 16, 2024

make check is executing tests in parallel (when either GNU parallel or moreutils' parallel is available)

@Ovascos
Copy link
Contributor Author

Ovascos commented Feb 16, 2024

Note that this PR is tested with Mac and Linux only. I don't have a Windows+cygwin setup available.

@coveralls
Copy link

coveralls commented Feb 20, 2024

Coverage Status

coverage: 65.531%. remained the same
when pulling 62cc24f on Ovascos:check-parallel
into ecac3fd on SRI-CSL:master.

@ahmed-irfan
Copy link
Member

How do you specify the number of cores to use?

@Ovascos
Copy link
Contributor Author

Ovascos commented Feb 20, 2024

You can not. All cores are used.

@ahmed-irfan
Copy link
Member

You can not. All cores are used.

Is there an easy way to pass this number?

@Ovascos
Copy link
Contributor Author

Ovascos commented Feb 20, 2024

You can not. All cores are used.

Is there an easy way to pass this number?

I'll have a look.

@Ovascos Ovascos marked this pull request as draft February 21, 2024 01:06
@Ovascos Ovascos marked this pull request as ready for review February 21, 2024 02:33
@Ovascos
Copy link
Contributor Author

Ovascos commented Feb 21, 2024

Integrated check.sh within GNU make's token system to use limit the number of total parallel execution to the value specified by -j N

Copy link
Member

@ahmed-irfan ahmed-irfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ahmed-irfan ahmed-irfan merged commit d84ee0a into SRI-CSL:master Feb 21, 2024
15 checks passed
@Ovascos Ovascos deleted the check-parallel branch March 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants