fixes #164 Battle clear edi historical data #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvizek
changed the title
ErinCain
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Overall looks good to me. A couple of items to note:
- some NAs for stream that we should double check we are consistent on removing (looks like we remove for trap in standard format but not catch, or I am missing something)
- We may need to open an issue to handle the new site lbc.
- Agree it would be good to follow up on the data quality issues that we see persisting on the EDI package.
| mutate(stream = case_when(grepl("clear", site) ~ "clear creek", | ||
| grepl("battle", site) ~ "battle creek"), | ||
| site = case_when(site == "upper battle creek" ~ "ubc", | ||
| site == "lower battle creek" ~ "lbc", |
There was a problem hiding this comment.
lbc is a new site we didn't have data on that site before. Do we want to create an issue to add that to all our other tables/lookups?
There was a problem hiding this comment.
This lbc might have to do with a release location but no RST site
There was a problem hiding this comment.
Looked into this more and there are fish being caught at lbc and include spring chinook. Most of this data is prior to 2003 which we originally were not provided with. We should double check with Natasha about using this data but should also open an issue to add lbc to tables/lookups
data-raw/standard-format-data-prep/rst_catch_standard_format.Rmd
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls data from EDI for Battle and Clear and adds to the standard format scripts. In the pull script (data-raw/qc-markdowns/rst/battle_clear_edi.Rmd) I noted some TODOs. I would focus review on these and let me know what you think. We can discuss as needed.