Fix plum compatibility issue caused by 2.3.0 release #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
|
Can you rebase these changes into the latest main? |
pabloferz
requested changes
Jun 7, 2024
|
I'm a bit puzzled about the failing test I can see how this PR should impact that at all. I'll try to dig a bit into it. |
pabloferz
force-pushed
the
fix_plum_compat_2
branch
from
d9a019e
to
124d884
Compare
pabloferz
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix the issue #323. A new signature fetching mechanism will be used whenever the
plumversion is greater than2.3.0.