Invalidating initgroups memory cache by a single name does not work

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3718

• Created at 2018-04-24 16:44:45 by jhrozek
• Assigned to nobody

---

I found this bug while working on tests for the nss_ex interface, but even with the help of the design page, I'm not sure what would the best fix be, so I'm filing a ticket.

When a user is being invalidated from the initgroups memory cache, the sss_mmap_cache_invalidate function is passed the input name (e.g. user). Then the code goes to sss_mc_find_record where the name is used to generate the hash and the slot and an entry is found. But then we go to:

582         if (strcmp(key->str, t_key) == 0) {
583             break;
584         }

Which never matches, because the t_key is the unique name in case of the initgroup cache, so the comparison is always false..

There is a crude fix in PR #558 but it's probable that someone else will be doing a proper fix, so filing an issue is safer.

Comments

---

Comment from pbrezina at 2020-03-13 15:07:59

Metadata Update from @pbrezina:

• Issue tagged with: Future milestone

[alexey-tikhonov]

Pushed PR: #6128

• master
  • 810d922 - NSS: mem-cache: don't update domains other than the one where an entry was found.
  • cceb136 - NSS: fix initgroups store key (one of)
  • 7abc9cf - NSS: MC: no need to convert name to output format.
  • 1690ae1 - NSS MS: trivial simplification
  • ad7d1de - NSS MC: deleted misleading comment