Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC: 'sssd.api.*' should belong python-sssdconfig #1039

Closed
wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Member

sssd.api.conf and sssd.api.d/* are only used by python-sssdconfig,
not by sssd-common.

Resolves: #1038

`sssd.api.conf` and `sssd.api.d/*` are only used by python-sssdconfig,
not by sssd-common.

Resolves: SSSD#1038
@pbrezina
Copy link
Member

pbrezina commented May 5, 2020

Is it ok to own directories %dir %{_datadir}/sssd by multiple packages?

@alexey-tikhonov
Copy link
Member Author

Is it ok to own directories %dir %{_datadir}/sssd by multiple packages?

I think this falls under:
https://fedoraproject.org/wiki/PackagingDrafts/Revised_File_and_Directory_Ownership#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function.
or
https://en.opensuse.org/openSUSE:Specfile_guidelines#Ownership "Common directory for unrelated packages"

As python-sssdconfig doesn't require sssd-common to work properly, I think both packages should own this dir.

@pbrezina
Copy link
Member

pbrezina commented May 7, 2020

Thanks. Fedora guide says it quite explicitly that this ownership is perfectly fine and expected. Ack.

@pbrezina
Copy link
Member

pbrezina commented May 7, 2020

  • master
    • 5379fdd - SPEC: 'sssd.api.*' should belong python-sssdconfig
  • sssd-1-16
    • 0ecc498 - SPEC: 'sssd.api.*' should belong python-sssdconfig

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels May 7, 2020
@pbrezina pbrezina closed this May 7, 2020
pbrezina added a commit to pbrezina/sssd that referenced this pull request Jan 28, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- SSSD#1008
- SSSD#1039
- SSSD#5137
- SSSD@e698d53
- SSSD@7fbc7e3
pbrezina added a commit to pbrezina/sssd that referenced this pull request Jan 28, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- SSSD#1008
- SSSD#1039
- SSSD#5137
- SSSD@e698d53
- SSSD@7fbc7e3
pbrezina added a commit to pbrezina/sssd that referenced this pull request Feb 1, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- SSSD#1008
- SSSD#1039
- SSSD#5137
- SSSD@e698d53
- SSSD@7fbc7e3
pbrezina added a commit to pbrezina/sssd that referenced this pull request Feb 1, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- SSSD#1008
- SSSD#1039
- SSSD#5137
- SSSD@e698d53
- SSSD@7fbc7e3
pbrezina added a commit that referenced this pull request Feb 5, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- #1008
- #1039
- #5137
- e698d53
- 7fbc7e3

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
3v1n0 pushed a commit to 3v1n0/sssd that referenced this pull request Apr 8, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- SSSD#1008
- SSSD#1039
- SSSD#5137
- SSSD@e698d53
- SSSD@7fbc7e3

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
akuster pushed a commit to akuster/sssd that referenced this pull request May 18, 2021
There were several changes in upstream spec file that were not merged
in Fedora but fixed valid problems. These are:

- SSSD#1008
- SSSD#1039
- SSSD#5137
- SSSD@e698d53
- SSSD@7fbc7e3

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch: sssd-1-16 Target also sssd-1-16 branch Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sssd.api.conf and sssd.api.d should belong to python-sssdconfig package
2 participants