Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DESKPROFILE: Document it doesn't work when run as unprivileged user #516

Closed
wants to merge 1 commit into from
Closed

DESKPROFILE: Document it doesn't work when run as unprivileged user #516

wants to merge 1 commit into from

Conversation

fidencio
Copy link
Contributor

No description provided.

lslebodn
lslebodn reviewed Feb 16, 2018
View reviewed changes
src/man/sssd.conf.5.xml Outdated
@@ -2461,6 +2461,11 @@ pam_account_locked_message = Account locked, please contact help desk.
Default: <quote>id_provider</quote> is used if it
is set and can perform session related tasks.
</para>
<note>
In order to have this feature working as expected,
SSSD must be running as "root" and not as the "sssd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just convention that unprivileged user is called sssd by default.
But it is configurable.

./configure --help | grep -- -user
  --with-sssd-user=<user> User for running SSSD (root)

Therefore would be better to mention just unprivileged user.

@fidencio
Copy link
Contributor Author

fidencio commented Feb 20, 2018 •
edited
Loading

Changes done according to your suggestion.
Thanks for the review and I'm removing the "Changes Requested" label.

@fidencio
Copy link
Contributor Author

retest this please

@lslebodn
Copy link
Contributor

LGTM from content point of view.

@justin-stephenson could you check this PR as well?

@justin-stephenson
Copy link
Contributor

Okay from my side.

@lslebodn
Copy link
Contributor

Justin,
thank you for review

@lslebodn
Copy link
Contributor

I tried to figure out why centos CI is failing and I noticed that xml element note is not allowed in DTD

/usr/bin/xmllint --catalogs --postvalid --nonet --noent --xinclude --noout ../../../sssd/src/man/sssd.conf.5.xml
../../../sssd/src/man/sssd.conf.5.xml:2464: element note: validity error : Element note content does not follow the DTD, expecting (title? , (calloutlist | glosslist | bibliolist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | procedure | sidebar | anchor | bridgehead | remark | indexterm | beginpage)+), got (CDATA)
Document ../../../sssd/src/man/sssd.conf.5.xml does not validate
make[2]: *** [Makefile:938: sssd.conf.5] Error 3

I can see that on other places in sssd.conf.5.xml we use either

                        <para>
                            <emphasis>NOTE:</emphasis> Sudo rules are

or NOTE without emphasis

                        <para>
                            NOTE: The filter_groups option doesn't affect

I'm sorry that I did not notice that earlier.

@jhrozek
Copy link
Contributor

jhrozek commented Feb 22, 2018

I think it's OK to add the Accepted label since the centos CI is passing now.

@lslebodn
Copy link
Contributor

master:

@lslebodn lslebodn closed this Feb 22, 2018
@pbrezina pbrezina mentioned this pull request Apr 28, 2020
Closed
@sssd-bot sssd-bot mentioned this pull request May 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslebodn lslebodn lslebodn left review comments

Assignees
No one assigned
Labels
Accepted Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fidencio @lslebodn @justin-stephenson @jhrozek