sudo improvements #5610
Closed
sudo improvements #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fails because ldap_sudo_random_offset default to 30 instead of 0. I wonder if I should update the tests or change the default value to 0? |
|
@sgoveas Hi, this adds new option |
pbrezina
force-pushed
the
sudo-man
branch
2 times, most recently
from
9173976
to
44c5de5
Compare
|
The code looks good, works for me. I have just one comment: You titled one commit "be: add be_ptask_reschedule" but the function added is called *_postpone. Could you make that consistent for future search/reference? Tom |
This will cancel the next event and schedule it to now + period.
We postpone periodic full and smart refresh tasks when full refresh (either per-request or periodic) is finished. Resolves: SSSD#5604 :feature: Completing a sudo full refresh now postpones the smart refresh by `ldap_sudo_smart_refresh_interval` value. This ensure that the smart refresh is not run too soon after a successful full refresh.
Resolves: SSSD#5609 :feature: Backround sudo periodic tasks (smart and full refresh) periods are now extended by a random offset to spread the load on the server in environments with many clients. The random offset can be changed with `ldap_sudo_random_offset`. :config: Added `ldap_sudo_random_offset` (default to `30`) to add a random offset to backround sudo periodic tasks (smart and full refresh).
|
Done |
|
Thank you for the update, |
This was referenced May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: