SSSD Log: no_such_file_or_directory_modification #5622
Conversation
|
@elkoniu can you review it? |
|
Sure, will be done today. |
|
Hi Iker, Pawel, The error "No such file or directory" has been replaced with more relevant message "Machine is not on the network" since the earlier message was logged once fail over cycled through all available servers hence did not make sense. Regards, |
There was a problem hiding this comment.
Quoting /usr/include/asm/errno.h:
#define ENOENT 2 /* No such file or directory */
#define ENONET 64 /* Machine is not on the network */
In the be_resolve_server_process() we are jumping on top of server list.
After entry is validated error code is returned. I am wondering if the better replacement would not be:
#define EHOSTDOWN 112 /* Host is down */
@sumit-bose can you advice here? I saw that EHOSTDOWN is rarely used in SSSD.
There was a problem hiding this comment.
After giving it a second look I think it should be solved different.
ENOENT is used to tell that we tried all servers from the list and there is nothing more to check.
This is correct. The problem is that due to historical reasons it is printed as No such file or directory.
I thing that change should be done in function consuming this return - be_resolve_server_done (src/providers/data_provider_fo.c:578). This upper level function should check for ENOENT and align error message.
This is similar case to #5625
DDDas7
force-pushed
the
log_no_such_file_or_directory_modification
branch
from
265dc74
to
8c332cf
Compare
src/providers/data_provider_fo.c
Outdated
| "Server resolution failed: [%d]: %s\n", ret, sss_strerror(ret)); | ||
| if (ret == ENOENT) { | ||
| DEBUG(SSSDBG_TRACE_LIBS, | ||
| "Server resolution failed[%d]: All servers down\n", ret); |
There was a problem hiding this comment.
Style error - white space missing in between failed and opening [ bracket.
| "Server resolution failed[%d]: All servers down\n", ret); | ||
| } else { | ||
| DEBUG(SSSDBG_TRACE_LIBS, | ||
| "Server resolution failed: [%d]: %s\n", ret, sss_strerror(ret)); |
There was a problem hiding this comment.
In this line we have colon : after failed and brackets, where in upper line there is one after brackets. You may want to unify this to both have two or single colon.
There was a problem hiding this comment.
Hi Pawel,
I have made the necessary changes. Can you please review.
Thank you!
Replacing no such file or directory error code with alternate message Resolves: SSSD#5614
DDDas7
force-pushed
the
log_no_such_file_or_directory_modification
branch
from
8c332cf
to
4a5912f
Compare
Replacing no such file or directory error code with alternate message
Resolves: #5614