D-Bus: Do not use timestamp optimization on "files" provider. #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Therefore the last update flag is not updated if no file was touched | ||
| * and we cannot use this optimization. | ||
| */ | ||
| if (strcasecmp(domain->provider, "files") == 0) { |
There was a problem hiding this comment.
Would it be possible to use is_files_provider() from util.h?
There was a problem hiding this comment.
Nice. Didn't know that function existed. Thanks.
aplopez
force-pushed
the
list-by-name
branch
from
ebe4c79
to
0f10d8e
Compare
alexey-tikhonov
approved these changes
Sep 13, 2022
|
@aplopez Can you please write test for it? |
|
Otherwise ack to the code. |
aplopez
force-pushed
the
list-by-name
branch
from
0f10d8e
to
4f8f3c2
Compare
|
Added a as requested by @pbrezina |
pbrezina
requested changes
Sep 20, 2022
| #define TESTS_PATH "tp_" BASE_FILE_STEM | ||
| #define TEST_CONF_DB "test_responder_cache_req_conf.ldb" | ||
| #define TEST_DOM_NAME "responder_cache_req_test" | ||
| #define TEST_ID_PROVIDER "ldap" | ||
| #define TEST_ID_PROVIDER LDAP_ID_PROVIDER |
There was a problem hiding this comment.
Since you defined both FILES_ID_PROVIDER and LDAP_ID_PROVIDER then I think you can just delete this macro and replace it with LDAP_ID_PROVIDER?
Avoid requesting only the latest updates when using the "files" provider as it only updates the cache if /etc/files or /etc/group is touched. Added a test for this situation. Resolves: SSSD#6342
aplopez
force-pushed
the
list-by-name
branch
from
4f8f3c2
to
7613d46
Compare
pbrezina
approved these changes
Sep 23, 2022
pbrezina
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid requesting only the latest updates when using the "files" provider as it only updates the cache if /etc/files or /etc/group is touched.
Resolves: #6342