Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS: Ported over dyndns from downstream to upstream #6344

Closed
wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 9, 2022

  • Updated code to use current libs from factory.py
  • Created fixtures to add an additional zone file, additional interface, retrieve the PTR record
  • Added bind-utils as a required package to utils.py

Signed-off-by: Dan Lavu dlavu@redhat.com

src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code looks good. I have mostly a small suggestions to imporove it,

@danlavu
Copy link
Author

danlavu commented Sep 9, 2022

I updated the lines, and noticed the wrap is set to 120 instead of 100, it should be easier to read now.

src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
src/tests/multihost/ad/test_dyndns.py Fixed Show fixed Hide fixed
@jakub-vavra-cz
Copy link
Contributor

The decorator @staticmethod needs to be added.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things to take a look at.

src/tests/multihost/ad/test_dyndns.py Show resolved Hide resolved
src/tests/multihost/ad/test_dyndns.py Show resolved Hide resolved
src/tests/multihost/ad/test_dyndns.py Show resolved Hide resolved
* Updated code to use current libs from factory.py
* Created fixtures to add an additional zone file, additional interface, retrieve the PTR record
* Added bind-utils as a required package to utils.py

Signed-off-by: Dan Lavu <dlavu@redhat.com>
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LTGM. we can cover some of the other non-vital suggestions in the next PR which adds more test cases.

@danlavu
Copy link
Author

danlavu commented Sep 26, 2022

There are a lot of changes on the next patch. #6363

@spoore1
Copy link
Contributor

spoore1 commented Sep 27, 2022

@justin-stephenson can you tell why the flake8 tests here are failing now?

@justin-stephenson
Copy link
Contributor

@justin-stephenson can you tell why the flake8 tests here are failing now?

It looks like the GH Action failed when attempting to post the results into the PR, but running flake8 manually shows:

[justin@fedora sssd]$ flake8 src/tests/multihost/ad/test_dyndns.py 
src/tests/multihost/ad/test_dyndns.py:172:120: E501 line too long (122 > 119 characters)
src/tests/multihost/ad/test_dyndns.py:311:1: W391 blank line at end of file

@andreboscatto
Copy link
Contributor

@sidecontrol Is any comment from @jakub-vavra-cz pending to merge this PR?

@danlavu
Copy link
Author

danlavu commented Oct 31, 2022

There is another PR that is a branch of, this will not pass any of tests so I'm creating a new PR so I can drop this intermediary branch.

@danlavu danlavu closed this Oct 31, 2022
@danlavu danlavu deleted the tests-dyndns branch April 25, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants