-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: port bash rfc2307 to pytest #6543
Conversation
1890225
to
31b3e96
Compare
31b3e96
to
7380b89
Compare
1fa0c97
to
bf4d7f2
Compare
bf4d7f2
to
18606c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
088c77c
to
a140591
Compare
bf0e1cd
to
8405af2
Compare
8405af2
to
be9c544
Compare
user = f'user\\{sp_char}{r_num}@{domain_name}' | ||
grp_n = f'grp\\{sp_char}{r_num}@{domain_name}' | ||
cmd = multihost.client[0].run_command(f'id {user}', raiseonerr=False) | ||
cmd_returnc0de = cmd.returncode |
Check notice
Code scanning / CodeQL
Unused local variable
grp_n = f'grp\\{sp_char}{r_num}@{domain_name}' | ||
cmd = multihost.client[0].run_command(f'id {user}', raiseonerr=False) | ||
cmd_returnc0de = cmd.returncode | ||
ssh1 = tools.auth_from_client(f'{user}', 'Secret123') == 3 |
Check notice
Code scanning / CodeQL
Unused local variable
9d65f15
to
fc285da
Compare
fc285da
to
79b0bf6
Compare
79b0bf6
to
20ef20d
Compare
""" | ||
tools = sssdTools(multihost.client[0]) | ||
domain_name = tools.get_domain_section_name() | ||
start = multihost.client[0].service_sssd('start') |
Check notice
Code scanning / CodeQL
Unused local variable
'uidNumber': f'22222', | ||
'gidNumber': f'22222'} | ||
usr_grp(multihost, usr_info, 'user', 'add') | ||
memberdn = f'uid=testuser1,ou=People,{ds_suffix}' |
Check warning
Code scanning / CodeQL
Variable defined multiple times
'memberUid': f'TESTUSER1' | ||
} | ||
usr_grp(multihost, group_info, 'group', 'add') | ||
memberdn = f'uid=TESTuser2,ou=People,{ds_suffix}' |
Check notice
Code scanning / CodeQL
Unused local variable
ad48ff3
to
b056abe
Compare
b056abe
to
edbdc21
Compare
edbdc21
to
c6f6684
Compare
ef34a91
to
961d407
Compare
tools.clear_sssd_cache() | ||
mesg_log = '/var/log/messages' | ||
segf_pat = re.compile(r'segfault at') | ||
log = multihost.client[0].get_file_contents(logfile).decode('utf-8') |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
tools.clear_sssd_cache() | ||
mesg_log = '/var/log/messages' | ||
segf_pat = re.compile(r'segfault at') | ||
log = multihost.client[0].get_file_contents(logfile).decode('utf-8') |
Check notice
Code scanning / CodeQL
Unused local variable
'memberUid': f'{usr}', | ||
'uniqueMember': memberdn} | ||
usr_grp(multihost, group_info, 'group', 'add') | ||
user = f'{usr}@{domain_name}' |
Check warning
Code scanning / CodeQL
Variable defined multiple times
domain_name = tools.get_domain_section_name() | ||
r_num = random.randint(9999, 99999) | ||
usr = f'user{r_num}' | ||
user = f'{usr}@{domain_name}' |
Check notice
Code scanning / CodeQL
Unused local variable
961d407
to
c504a77
Compare
bb954e9
to
f13c050
Compare
558beb0
to
09f6f68
Compare
minor code rearrangement
Porting bash rfc2307 to pytest, added two more
tests