MONITOR: fix socket_activated flag initialization
#6575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
reviewed
Feb 16, 2023
alexey-tikhonov
force-pushed
the
monitor-fix-socket_activated
branch
from
a898e85
to
0994901
Compare
@spoore1, could you please help - what is better in this context? |
|
I believe 'for the first time' is correct in this context. |
When socket activated service connects for the first time, it is added to `mt_ctx->svc_list` by `socket_activated_service_not_found()` with a proper `socket_activated = true`. But when it reconnects again, `get_service_in_the_list()` finds it in `mt_ctx->svc_list` and overwrites `socket_activated = false` unconditionally. This patch moves `socket_activated = false` to `start_service()`. Resolves: SSSD#6324
alexey-tikhonov
force-pushed
the
monitor-fix-socket_activated
branch
from
0994901
to
e0f2079
Compare
pbrezina
approved these changes
Feb 17, 2023
ikerexxe
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When socket activated service connects for a first time, it is added to
mt_ctx->svc_listbysocket_activated_service_not_found()with a propersocket_activated = true.But when it reconnects again,
get_service_in_the_list()finds it inmt_ctx->svc_listand overwritessocket_activated = falseunconditionally. This patch moves movessocket_activated = falsetostart_service().Resolves: #6324