Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add a timeout to realm join for AD, modify realm leave. #6658

Closed

Conversation

jakub-vavra-cz
Copy link
Contributor

The realm join gets stuck on other architectures particularly on s390x. This makes it fail and suite can continue running instead of waiting for timeout for the whole suite.
Handle the edge case when realm leave fails for the machine and removal from AD is also not done resulting in the following tests unable to join as the machine is already present on AD.

@jakub-vavra-cz
Copy link
Contributor Author

The result is:
2023-04-04T16:57:13 = 1 failed, 96 passed, 2 skipped, 39 deselected, 7 warnings, 3 errors in 10813.03s (3:00:13) =

The realm join gets stuck on other architectures particularly on s390x.
This makes it fail and suite can continue running instead of waiting
for timeout for the whole suite.
Handle the edge case when realm leave fails for the machine and removal from AD
is also not done resulting in the following tests unable to join as the machine
is already present on AD.
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain if backing sssd.conf is needed, I don't see why it is. The other comment is something to consider, does not need to be done in this patch.

src/tests/multihost/ad/conftest.py Show resolved Hide resolved
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz
Copy link
Contributor Author

Pushed PR: #6658

  • master
    • bc5de68 - Tests: Add a timeout to realm join for AD, modify realm leave.
  • sssd-2-7
    • a19740a - Tests: Add a timeout to realm join for AD, modify realm leave.
  • sssd-2-8
    • 2c54549 - Tests: Add a timeout to realm join for AD, modify realm leave.

@jakub-vavra-cz jakub-vavra-cz deleted the multiarch_realm_join branch October 18, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants