-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add a timeout to realm join for AD, modify realm leave. #6658
Conversation
The result is: |
355bad7
to
d70c8d8
Compare
The realm join gets stuck on other architectures particularly on s390x. This makes it fail and suite can continue running instead of waiting for timeout for the whole suite. Handle the edge case when realm leave fails for the machine and removal from AD is also not done resulting in the following tests unable to join as the machine is already present on AD.
d70c8d8
to
ff7b7fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain if backing sssd.conf is needed, I don't see why it is. The other comment is something to consider, does not need to be done in this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The realm join gets stuck on other architectures particularly on s390x. This makes it fail and suite can continue running instead of waiting for timeout for the whole suite.
Handle the edge case when realm leave fails for the machine and removal from AD is also not done resulting in the following tests unable to join as the machine is already present on AD.