Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: split system test framework into standalone repository #6670

Closed
wants to merge 1 commit into from
Closed

tests: split system test framework into standalone repository #6670

wants to merge 1 commit into from

Conversation

pbrezina
Copy link
Member

This change allows other project to use the framework as well.

https://github.com/SSSD/sssd-test-framework

jakub-vavra-cz
jakub-vavra-cz approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz jakub-vavra-cz self-assigned this Apr 13, 2023
ikerexxe
ikerexxe approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but I have a minor comment.

https://github.com/SSSD/sssd-test-framework

I wouldn't have added the sssd prefix to the name, as it gives the idea that it can only test sssd when in reality it can be used for any IdM project testing.

@pbrezina
Copy link
Member Author

IMHO it is still strongly related to SSSD. Selected parts can be reused by other projects, but the framework as a whole aims for SSSD. And all other repositories are currently prefix with sssd.

@pbrezina pbrezina added Ready to push Ready to push backport-to-stable and removed Ready to push Ready to push labels Apr 17, 2023
@pbrezina
Copy link
Member Author

  • master
    • c3a0b5f - tests: split system test framework into standalone repository
  • sssd-2-8
    • 2426cb8 - tests: split system test framework into standalone repository

@pbrezina pbrezina closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

Assignees

@ikerexxe ikerexxe

@jakub-vavra-cz jakub-vavra-cz

Labels
Accepted Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbrezina @ikerexxe @jakub-vavra-cz