-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passkey: don't print User ID #6675
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
added
passkey
Issues and PRs related to 'passkey' feature
Waiting for review
labels
Apr 14, 2023
justin-stephenson
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Rebased on top of master to get rid of the CI failure. |
sumit-bose
reviewed
Apr 26, 2023
The User ID isn't part of any signed data, thus there isn't any indication that it's related to the token. Moreover, the effort to store it securely on the LDAP attribute is quite big. Taking that into account the passkey child doesn't print it and this way we avoid storing it in the LDAP server. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
sumit-bose
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
since the CI failures are not related, ACK.
bye,
Sumit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-backport
This should go to target branch only.
passkey
Issues and PRs related to 'passkey' feature
Pushed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The User ID isn't part of any signed data, thus there isn't any indication that it's related to the token. Moreover, the effort to store it securely on the LDAP attribute is quite big. Taking that into account the passkey child doesn't print it and this way we avoid storing it in the LDAP server.
passkey_child testing
Register key
Authentication
Assertion obtention
Assertion validation
End to end testing
Use the COPR repository