Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add passkey test cases for following scenario. #6727

Closed

Conversation

madhuriupadhye
Copy link
Contributor

@madhuriupadhye madhuriupadhye commented May 12, 2023

Test cases are as follows:
4. Check auth deny for incorrect pin for LDAP and IPA.
5. Check auth deny for incorrect passkey mapping for LDAP and IPA.
6. Check auth of user when server is not resolvable for IPA and LDAP.

First PR is under review, #6634

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good but there are some minor comments.

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
@ikerexxe
Copy link
Contributor

In general terms, it looks good to me. We are still missing the marker to skip the tests in those distributions where passkey isn't available, but you can't add them until we implement them. So, I'd keep this PR as it is until we can add those markers.

Thanks for your hard work!

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two commits, one with the changes and one merge, you should remove the former as we don't use merges but rebases.

Apart from that, there's a minor comment inline.

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked many instances of "authenticate" with a comment to "Add su" because we received input a few weeks ago about being more specific when we talk about authentication. We need to specify how the user is authenticating as the method could be different in different cases/scenarios and we need to make sure we're describing what we're actually testing. I agree with this and think we should follow that advice.

Besides that mostly just a question about your use of checking provider name for suffix as the way to check which one is in use.

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
@madhuriupadhye madhuriupadhye force-pushed the test_passkey_part2 branch 2 times, most recently from e67c96f to 4150763 Compare November 24, 2023 09:53
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor correction in the module docstring.

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
@madhuriupadhye madhuriupadhye force-pushed the test_passkey_part2 branch 4 times, most recently from 6485f73 to 4f96319 Compare November 27, 2023 16:20
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor change that I missed earlier for the comment in test_passkey__su_fail_mapping.

src/tests/system/tests/test_passkey.py Show resolved Hide resolved
  Test cases are as follows:
  4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba.
  5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba.
  6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba.

  First PR is under review, SSSD#6634

Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your patience and hard work. I know it has taken time to get everything polished and ready to be merged.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all of your effort here!

@pbrezina
Copy link
Member

pbrezina commented Dec 5, 2023

  • master
    • f4c9d6e - tests: add passkey tests for authentication failures
  • sssd-2-9
    • a8928a9 - tests: add passkey tests for authentication failures

@pbrezina pbrezina closed this Dec 5, 2023
@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passkey Issues and PRs related to 'passkey' feature Pushed Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants