Tests: Add passkey test cases for following scenario. #6727

madhuriupadhye · 2023-05-12T07:09:14Z

Test cases are as follows:
4. Check auth deny for incorrect pin for LDAP and IPA.
5. Check auth deny for incorrect passkey mapping for LDAP and IPA.
6. Check auth of user when server is not resolvable for IPA and LDAP.

First PR is under review, #6634

ikerexxe

Some minor comments.

src/tests/system/tests/test_passkey.py

ikerexxe

Overall it looks good but there are some minor comments.

src/tests/system/tests/test_passkey.py

ikerexxe · 2023-08-31T07:06:20Z

In general terms, it looks good to me. We are still missing the marker to skip the tests in those distributions where passkey isn't available, but you can't add them until we implement them. So, I'd keep this PR as it is until we can add those markers.

Thanks for your hard work!

ikerexxe

There are two commits, one with the changes and one merge, you should remove the former as we don't use merges but rebases.

Apart from that, there's a minor comment inline.

src/tests/system/tests/test_passkey.py

spoore1

I marked many instances of "authenticate" with a comment to "Add su" because we received input a few weeks ago about being more specific when we talk about authentication. We need to specify how the user is authenticating as the method could be different in different cases/scenarios and we need to make sure we're describing what we're actually testing. I agree with this and think we should follow that advice.

Besides that mostly just a question about your use of checking provider name for suffix as the way to check which one is in use.

src/tests/system/tests/test_passkey.py

spoore1

Just a minor correction in the module docstring.

src/tests/system/tests/test_passkey.py

spoore1

Only minor change that I missed earlier for the comment in test_passkey__su_fail_mapping.

src/tests/system/tests/test_passkey.py

Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>

ikerexxe

LGTM! Thank you for your patience and hard work. I know it has taken time to get everything polished and ready to be merged.

spoore1

LGTM. Thanks for all of your effort here!

pbrezina · 2023-12-05T21:11:28Z

master
- f4c9d6e - tests: add passkey tests for authentication failures
sssd-2-9
- a8928a9 - tests: add passkey tests for authentication failures

madhuriupadhye force-pushed the test_passkey_part2 branch from 4480a5a to 0f9b578 Compare May 12, 2023 15:56

ikerexxe reviewed Jun 1, 2023

View reviewed changes

ikerexxe added Changes requested passkey Issues and PRs related to 'passkey' feature labels Jun 13, 2023

alexey-tikhonov added the Tests label Aug 14, 2023

madhuriupadhye force-pushed the test_passkey_part2 branch 2 times, most recently from 074f569 to 5782acb Compare August 29, 2023 10:32

madhuriupadhye added Waiting for review and removed Changes requested labels Aug 29, 2023

madhuriupadhye requested a review from ikerexxe August 29, 2023 10:34

madhuriupadhye force-pushed the test_passkey_part2 branch from 5782acb to c3e5e90 Compare August 29, 2023 10:36

github-advanced-security bot found potential problems Aug 29, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Fixed Show resolved Hide resolved

ikerexxe requested changes Aug 29, 2023

View reviewed changes

ikerexxe assigned ikerexxe and jakub-vavra-cz Aug 29, 2023

madhuriupadhye force-pushed the test_passkey_part2 branch from c3e5e90 to 111b070 Compare August 29, 2023 13:40

madhuriupadhye requested a review from ikerexxe August 29, 2023 16:05

ikerexxe added Changes requested and removed Waiting for review labels Aug 30, 2023

madhuriupadhye force-pushed the test_passkey_part2 branch from 111b070 to 59c80fb Compare August 31, 2023 06:00

madhuriupadhye added Waiting for review and removed Changes requested labels Aug 31, 2023

andreboscatto added the Blocked label Sep 26, 2023

madhuriupadhye force-pushed the test_passkey_part2 branch from 59c80fb to 6d62489 Compare September 29, 2023 10:56

madhuriupadhye removed the Blocked label Oct 10, 2023

madhuriupadhye requested a review from jakub-vavra-cz October 10, 2023 09:38

ikerexxe requested changes Oct 19, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

spoore1 requested changes Nov 21, 2023

View reviewed changes

spoore1 mentioned this pull request Nov 22, 2023

Tests: Add passkey test cases for following scenario #6965

Closed

madhuriupadhye force-pushed the test_passkey_part2 branch from 7cb24fe to 7cb59eb Compare November 24, 2023 06:20

github-advanced-security bot found potential problems Nov 24, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Fixed Show fixed Hide fixed

madhuriupadhye force-pushed the test_passkey_part2 branch 2 times, most recently from e67c96f to 4150763 Compare November 24, 2023 09:53

spoore1 requested changes Nov 27, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

madhuriupadhye force-pushed the test_passkey_part2 branch 4 times, most recently from 6485f73 to 4f96319 Compare November 27, 2023 16:20

github-advanced-security bot found potential problems Nov 27, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Fixed Show fixed Hide fixed

src/tests/system/tests/test_passkey.py Fixed Show fixed Hide fixed

src/tests/system/tests/test_passkey.py Fixed Show fixed Hide fixed

madhuriupadhye force-pushed the test_passkey_part2 branch 2 times, most recently from 6727c97 to a9387c7 Compare November 27, 2023 18:18

madhuriupadhye requested a review from spoore1 November 27, 2023 18:20

madhuriupadhye force-pushed the test_passkey_part2 branch from a9387c7 to 243f729 Compare November 27, 2023 18:25

spoore1 requested changes Nov 27, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Show resolved Hide resolved

madhuriupadhye force-pushed the test_passkey_part2 branch from 243f729 to 41574ef Compare November 28, 2023 05:34

madhuriupadhye requested a review from spoore1 November 28, 2023 05:35

ikerexxe approved these changes Nov 28, 2023

View reviewed changes

spoore1 approved these changes Nov 28, 2023

View reviewed changes

jakub-vavra-cz approved these changes Nov 29, 2023

View reviewed changes

jakub-vavra-cz added Accepted Ready to push Ready to push backport-to-stable and removed Waiting for review labels Nov 29, 2023

pbrezina closed this Dec 5, 2023

pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests: Add passkey test cases for following scenario. #6727

Tests: Add passkey test cases for following scenario. #6727

madhuriupadhye commented May 12, 2023 •

edited

Loading

ikerexxe left a comment

ikerexxe left a comment

ikerexxe commented Aug 31, 2023

ikerexxe left a comment

spoore1 left a comment

spoore1 left a comment

spoore1 left a comment

ikerexxe left a comment

spoore1 left a comment

pbrezina commented Dec 5, 2023

Tests: Add passkey test cases for following scenario. #6727

Tests: Add passkey test cases for following scenario. #6727

Conversation

madhuriupadhye commented May 12, 2023 • edited Loading

ikerexxe left a comment

Choose a reason for hiding this comment

ikerexxe left a comment

Choose a reason for hiding this comment

ikerexxe commented Aug 31, 2023

ikerexxe left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

ikerexxe left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

pbrezina commented Dec 5, 2023

madhuriupadhye commented May 12, 2023 •

edited

Loading