Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: remove github actions badges #6861

Closed
wants to merge 1 commit into from
Closed

Conversation

pbrezina
Copy link
Member

@pbrezina pbrezina commented Aug 1, 2023

These badges stopped working due to breaking changes in the badge
provider:
badges/shields#8671

I don't think we really use them and we did not even update from
sssd-2-7 branch to a newer one or with latest ci changes. Also it
is simple to see the green tick or red cross in github web ui so
these badges are redundant.

Covscan result is kept since you would need to check it on different
page.

These badges stopped working due to breaking changes in the badge
provider:
badges/shields#8671

I don't think we really use them and we did not even update from
sssd-2-7 branch to a newer one or with latest ci changes. Also it
is simple to see the green tick or red cross in github web ui so
these badges are redundant.

Covscan result is kept since you would need to check it on different
page.
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pbrezina pbrezina added the Ready to push Ready to push label Aug 7, 2023
@pbrezina
Copy link
Member Author

pbrezina commented Aug 7, 2023

CI failure is not related.

@pbrezina
Copy link
Member Author

pbrezina commented Aug 7, 2023

Pushed PR: #6861

  • master
    • dd21de8 - readme: remove github actions badges
  • sssd-2-8
    • aa8d673 - readme: remove github actions badges
  • sssd-2-9
    • 0b5d3ab - readme: remove github actions badges

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Aug 7, 2023
@pbrezina pbrezina closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants