Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add support for IPA IPA Trust #7517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests: Add support for IPA IPA Trust #7517

wants to merge 1 commit into from

Conversation

justin-stephenson
Copy link
Contributor

Add tests for new IPA Trust topologies in SSSD test framework.

Linked PRs:

SSSD/sssd-ci-containers#106
SSSD/sssd-test-framework#119

This was referenced Aug 1, 2024
Open
Open
@justin-stephenson justin-stephenson marked this pull request as ready for review August 1, 2024 13:43
@justin-stephenson justin-stephenson force-pushed the ipa_ipa_trust_tests branch 2 times, most recently from 8abd754 to 644678a Compare August 2, 2024 20:02
danlavu
danlavu reviewed Aug 6, 2024
View reviewed changes
src/tests/system/tests/test_ipa_trusts.py Outdated

@pytest.mark.importance("low")
@pytest.mark.topology(KnownTopologyGroup.AnyIPATrust)
def test_ipa_trusts__ipa_server_trusted_user_lookup(ipa: IPA, trusted: IPA):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better name would be

test_ipa_trusts__on_the_ipa_master_lookup_a_trusted_user"

Just to make it a little clearer that the test doesn't use a client.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to test_ipa_trusts__ipa_master_lookup_trusted_user, just to be a bit more concise.

src/tests/system/tests/test_ipa_trusts.py Outdated

@pytest.mark.importance("low")
@pytest.mark.topology(KnownTopology.IPATrustIPA)
def test_ipa_trusts__ipa_client_trusted_user_lookup(client: Client, ipa: IPA, trusted: IPA):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like all the other tests, we can assume it uses the client.

test_ipa_trusts__lookup_a_trusted_user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to test_ipa_trusts__lookup_trusted_user

@justin-stephenson justin-stephenson force-pushed the ipa_ipa_trust_tests branch 4 times, most recently from d92d5a9 to c2ef19c Compare August 8, 2024 15:41
@pbrezina
Copy link
Member

Hi, I added blocked label since I think we should not merge it until new IPA is released. We should also add conditional skip based on feature detection.

@justin-stephenson
Copy link
Contributor Author

Updated mhc.yaml based on SSSD/sssd-test-framework#119 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlavu danlavu danlavu left review comments

@pbrezina pbrezina Awaiting requested review from pbrezina

@jakub-vavra-cz jakub-vavra-cz Awaiting requested review from jakub-vavra-cz

Assignees

@danlavu danlavu

@pbrezina pbrezina

@jakub-vavra-cz jakub-vavra-cz

Labels
Blocked Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justin-stephenson @pbrezina @danlavu @alexey-tikhonov @jakub-vavra-cz