Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipa: Nested netgroups do not work #78

Closed
wants to merge 1 commit into from

Conversation

mzidek-gh
Copy link
Contributor

We lowercase the keys to the hash table used to store netgroups
but do not lowercase it when reading the table. This results
in nested netgroups not being found when they should and
the processing fails.

The lowercasing does not seem to be necessary anymore (not
sure if it ever was) so we can skip it.

Resolves:
https://fedorahosted.org/sssd/ticket/3159

We lowercase the keys to the hash table used to store netgroups
but do not lowercase it when reading the table. This results
in nested netgroups not being found when they should and
the processing fails.

The lowercasing does not seem to be necessary anymore (not
sure if it ever was) so we can skip it.

Resolves:
https://fedorahosted.org/sssd/ticket/3159
@celestian celestian self-assigned this Nov 11, 2016
@jhrozek
Copy link
Contributor

jhrozek commented Nov 11, 2016

btw just to help with the review, I also fired up a test job using our downstream tests with a 7.3 package and this test. I'll let you know how the test went.

@celestian
Copy link
Contributor

Code LGTM.
CI passed: http://sssd-ci.duckdns.org/logs/job/56/99/summary.html

And I tested it manually:

Setup FreeIPA server and do the following:
1. create two netgroups - ng1, ng2
2. add user1 to ng1
3. add user2 to ng2
4. add ng2 to ng1 (make ng2 member of ng1)
5. run command:
$ getent netgroup ng1

Wrong output: you do not see netgroup members
Correct output: You shoudl see all members of ng1 and ng2

@jhrozek , I give conitional ACK to this patch if downstream tests passed.

@jhrozek
Copy link
Contributor

jhrozek commented Nov 14, 2016

The downstream tests passed (the job ID is 1594128 if anyone wants to take a look).

So I'm adding the Accepted tag.

@jhrozek
Copy link
Contributor

jhrozek commented Nov 14, 2016

master: ff565da
sssd-1-14: 7de3387
sssd-1-13: 9c4c3a2

@jhrozek jhrozek closed this Nov 14, 2016
@jhrozek jhrozek added Pushed and removed Accepted labels Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants