v2 #26
Merged
v2 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. This current setup is optimized to be able to run the first script (ColorMania); so, there are more works to do which follows. 3. "label", "floatedit", and "dropdown" elements from lua GUIs are converted to pyqt widgets (for "floatedit" element the conversion works for the ColorMania script but needs to be improved to better reflect its parent. Other elements of lua GUIs need to be converted to pyqt widgets. 4. Right now, the scripts will be applyed on all of the subtitle lines. This needs to be modified so that we can have the option to apply the scripts on the selected line(s) as well as filtering the lines based on some of their attributes (e.g. actor, style, etc. 5. The "settings.json" files need to have a "format" field so that we can identify in which environment the developers are presenting their GUIs' settings; for example in the ColorMania script, the setting.json file is structured based on lua GUIs format.
- deleted some unnecessary files
- changed the QLineEdit to QDoubleSpinBox for conversion from lua's floatedit element
fix variable namings some cleanups
…. The parameters of some of the widgets are yet to be set.
…alpha=255 means being transparent).
…at are the settings based on (currently supporting Lua). - Divided the "main.py" representing the main GUI into two separate files second of which implements the second window. - Some functionalities improved (like closing the second window using canceel button and restructured some of the functions).
…was mistakenly replaced by an older version.
…added without delay on showing the GUIs. - The structure of the main lua file changed in order to account for the interactions between lua and PyQt.
- Producing new lines organized. - A new feature provided for the developers: they can choose whether the original lines get commented, deleted, or unchanged.
…erated. - Modified the structure of the "settings.json" and "main.py" files for the sample scripts. Therefore, any scripts (if by a minute chance, any!) which were written based on the previous structure won't be supported anymore!
… of the windows. These elements may be defined by a "G_" at the beginning of their name.
…ced lines to be placed at the end of subtitle file, at the start of it, or below the corresponding original line(s).
cleanups
Major changes to the version 1
move gui files to the right folder comment out logs in lua
…eometry for each of them)
- Handled few errors for lua script (for when Cancel button is pushed in GUIs).
- Added margins and spacing.
- Themes can be switched using Settings button of the main GUI.
… avoiding the download of the same library multiple times as well as reducing the required space on hard disk. - Minor changes to the Pyegi theme. - Renamed some of the folders to better match the purpose.
- Modified install function. - Cleaned up and organized dome of the files and folders.
…for no directory in order to avoid library updating issues.
fix changing windows size when you first show a preview fix layout on settings optimize copy2aegisub task
…e PR. - Removes the previous installed venv before installing a new one.
improve set_style fix lua log level fix renewing temp folder in install_pkgs change second window's width to keep consistancy fix copy script's bug
DrunkSimurgh
approved these changes
Jul 30, 2022
This was referenced Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ui migrated to python.
Some lingering still remain: