Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

Refactor Busy out of CatchingPage #1484

Merged
merged 2 commits into from
Sep 1, 2016
Merged

Refactor Busy out of CatchingPage #1484

merged 2 commits into from
Sep 1, 2016

Conversation

jakubsuchybio
Copy link
Collaborator

@jakubsuchybio jakubsuchybio commented Aug 31, 2016

Change details

  • Remove Busy from CatchingPage
  • Remove server-side InventoryUpdate and replace it with local descreasing of thrown items
  • Disabled wrong state after catching
  • Removed 5s wait when missed

Other informations

  • Wrong state was, when you catch pokemon, then the pokeballButton got enabled and you could click it and break the game or maybe get yourself banned because it would send another catch request for already catched pokemon...


// We always need to update the inventory
if (catched)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about this. We need to update the inventory even if the Pokemon escaped or we're not showing the correct Pokeball amount. Doing lastused.Count-- is not enough because the user may switch to another ball and then switch back, seeing the wrong value.

@ST-Apps ST-Apps added this to the PoGo-UWP 1.1.0 milestone Sep 1, 2016
@ST-Apps ST-Apps merged commit 8f7e48e into ST-Apps:master Sep 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants