Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1: Generic CSV import supported #2

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix #1: Generic CSV import supported #2

merged 2 commits into from
Mar 15, 2024

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the DEH-CSV code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #1

  • Support of CSV import implemented, based on defined JSON mapping function

samatstariongroup
samatstariongroup approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update the quick start section of the README and have a think on how to send this data to a COMET server

DEH-CSV.Tests/CsvReaderTestFixture.cs Outdated
// -------------------------------------------------------------------------------------------------
// <copyright file="CsvReaderTestFixture.cs" company="RHEA System S.A.">
//
// Copyright 2023 RHEA System S.A.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-2024

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoineatstariongroup antoineatstariongroup merged commit 1614e4b into development Mar 15, 2024
3 checks passed
@antoineatstariongroup antoineatstariongroup deleted the feat/gh1-generic-csv-import branch March 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatstariongroup samatstariongroup samatstariongroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement generic CSV import capability
2 participants
@antoineatstariongroup @samatstariongroup