Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read variables from other sources when using files #218

Merged
merged 19 commits into from
Dec 20, 2023
Merged

feat: read variables from other sources when using files #218

merged 19 commits into from
Dec 20, 2023

Conversation

bryan-stclab
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

Which issue/s this PR fixes

#164

How Has This Been Tested?

Checklist:

@bryan-stclab
feat(data-layer): add config mapper
52fb88f
@bryan-stclab
fix(data-layer): edit variables example sample
0da380b
@bryan-stclab
feat(data-layer): remove original code in definition reader
19023ce
@bryan-stclab
feat(data-layer): add config mapper featrues and test codes
329074f
@bryan-stclab
fix(data-layer): edit variable name from file string to definition st…
597e931 
…ring
@bryan-stclab
feat(data-layer): add transformation data for metric, plan, and scali…
7beae28 
…ng component
@bryan-stclab
feat(data-layer): add samples for reading variables from other sources
5f0890c
@bryan-stclab
feat(data-layer): add config mapper to data-layer
04717e2
@bryan-stclab
feat(data-layer): add config mapper
7a151da
@bryan-stclab
fix(data-layer): edit config mapper test codes
34a7861
@bryan-stclab
fix(data-layer): edit test code with changed dynamic variables
e082215
@bryan-stclab
feat(data-layer): add config mapper
77aedd5
@bryan-stclab
refactor(data-layer): edit variable names
375b44d
@bryan-stclab
feat(data-layer): add and edit for config mapper
fcdb0e5
@bryan-stclab
feat(data-layer): add config mapper features
75c6379
@bryan-stclab
fix(web-app): add auto indentation file
0034f4a
@bryan-stclab bryan-stclab added this to the v0.1.0 milestone Dec 19, 2023
@bryan-stclab bryan-stclab self-assigned this Dec 19, 2023
@bryan-stclab bryan-stclab linked an issue Dec 19, 2023 that may be closed by this pull request
Read variables from other sources when using files #164
Closed
pueding
pueding requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@pueding pueding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name "config_mapper" to "variable_mapper" (including the related names)

core/data-layer/src/data_layer.rs Outdated Show resolved Hide resolved
core/data-layer/src/data_layer.rs Outdated Show resolved Hide resolved
@pueding pueding merged commit 0031168 into main Dec 20, 2023
1 check passed
@pueding pueding deleted the 164-read-variables-from-other-sources-when-using-files branch December 20, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pueding pueding pueding approved these changes

Assignees

@bryan-stclab bryan-stclab

Labels
target: data-layer
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Read variables from other sources when using files
2 participants
@bryan-stclab @pueding